DM-23077: Change default behavior for interpolate #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
approved these changes
Jan 15, 2020
| accepted values. | ||
| bounds_error : `bool`, optional | ||
| Raise error if interpolating outside the range of x | ||
| (default is False)? |
There was a problem hiding this comment.
I'd put the question mark at the end of the line above and have the default state as a distinct item. Otherwise I keep thinking I'm being asked what the default is. Also add a Raises section to the docstring saying what this exception might be.
The default was to raise an error if interpolating outside the bounds of the curve. The default now is to clamp to 0. outside the range of the curve.
SimonKrughoff
force-pushed
the
tickets/DM-23077
branch
from
2417cd9
to
1df8661
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default was to raise an error if interpolating outside the bounds of the curve. The default now is to clamp to 0. outside the range of the curve.