DM-24472: Regenerate Gaia DR2 catalogs to correct coordinate error fields #196
Conversation
Splitting out the validation tests, lets them run independently of the actual ingest tests; they don't need any setUp, and failed validations cause the ingest setUp to fail, so the validate tests wouldn't run.
There was a problem hiding this comment.
Looks good for what has been changed, but I noticed that the units of the ra/dec columns of the input catalogs are not configurable, and the fact that these should be in degrees is not documented in the config descriptions. It might be worth adding a coord_unit config, or if that's out-of-scope, at least make sure the ra_name and dec_name configs specify that it is expecting this column to be degrees.
|
Good point: I've added a note to the Config. That field being in different units would show up when running |
Use astropy.units to get the units correct, and test that they came out right.
parejkoj
force-pushed
the
tickets/DM-24472
branch
from
e17cfbe
to
e9a6637
Compare
No description provided.