DM-25979: IngestIndexReferenceTask throws if coord_err_unit is None #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdswinbank
force-pushed
the
tickets/DM-25979
branch
from
800a7a0
to
154f261
Compare
parejkoj
reviewed
Jul 16, 2020
tests/test_htmIndex.py
Outdated
| loader = LoadIndexedReferenceObjectsTask(butler=dafPersist.Butler( | ||
| self.outPath + "/output_setsVersion")) | ||
| self.assertEqual(loader.dataset_config.format_version, 1) | ||
| for withRaDecErr in (True, False): |
There was a problem hiding this comment.
Can you please break this block out as check_version() or some such, and then explicitly call it twice? The for loop over two items can be a bit harder to debug.
| @@ -68,6 +70,10 @@ def testIngestTwoFilesTwoCores(self): | |||
| self.checkAllRowsInRefcat(loader, skyCatalog1, config) | |||
| self.checkAllRowsInRefcat(loader, skyCatalog2, config) | |||
|
|
|||
| def testIngestTwoFilesTwoCores(self): | |||
| for withRaDecErr in [True, False]: | |||
| self._run_testIngestTwoFilesTwoCores(withRaDecErr) | |||
There was a problem hiding this comment.
Can you please make this two separate calls? That way, if one fails, it will be much more obvious which one.
jdswinbank
force-pushed
the
tickets/DM-25979
branch
from
154f261
to
9b4eaaf
Compare
jdswinbank
force-pushed
the
tickets/DM-25979
branch
from
9b4eaaf
to
8c1f58e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AKA “that looks more fun than proof rereading slides”.