DM-26007: defaultFilter is not used if a filterName is given to loadSkyCircle #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-owen
requested changes
Jul 20, 2020
There was a problem hiding this comment.
I am not entirely clear why we ended up specifying a default filter without also having a filter map, but assuming there are good reasons for that, the idea of this change seems sensible. However, I feel the implementation is too loose, as it also allows misspelled filter names to silently map to "camFlux" when there is a filter map.
parejkoj
force-pushed
the
tickets/DM-26007
branch
from
36c540d
to
fe5adc1
Compare
r-owen
approved these changes
Aug 2, 2020
anyFilterMapsToThis is exclusive with filterMap, so validate that.
parejkoj
force-pushed
the
tickets/DM-26007
branch
from
fe5adc1
to
59203ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.