DM-27502: Numpydoc conversion of meas_algorithms through makeCoaddApCorrMap.py #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squisty
force-pushed
the
tickets/DM-27502
branch
2 times, most recently
from
37dce95
to
15d457a
Compare
|
Please try to do a local build (on lsst-devl) and fix those problems and push again: I'm getting build failures due to incomplete markup (looks like you didn't delete all of the unused boilerplate for e.g. examples). See this for the steps: https://developer.lsst.io/stack/building-single-package-docs.html |
parejkoj
reviewed
Jan 22, 2021
There was a problem hiding this comment.
It looks like IngestIndexedReferenceTask and IngestGaiaReferenceTask are not appearing in the built "Task reference" section. The HTML files themselves do appear though. I'm not sure what's going on there: I don't see any obviously relevant errors or warnings.
| @return a catalog of reference objects in bbox, with centroid and hasCentroid fields set | ||
| Returns | ||
| ------- | ||
| A catalog of reference objects in bbox, with centroid and hasCentroid fields set |
There was a problem hiding this comment.
I think this should be:
catalog: `lsst.afw.table.SimpleCatalog`
Reference objects in the bbox, with centroid and hasCentroid fields set.
|
|
||
| Returns | ||
| ------- | ||
| Aperture corrections |
There was a problem hiding this comment.
I think this should be:
apCorrMap: `lsst.afw.image.ApCorrMap`
Aperture corrections
1012122
to
8bfc55b
Compare
parejkoj
approved these changes
Feb 3, 2021
Added ingestGaiaReferenceTask, LoadReferenceObjectsTask, InstallGaussianPsfTask task topic types
squisty
force-pushed
the
tickets/DM-27502
branch
from
9008220
to
c6a8886
Compare
squisty
force-pushed
the
tickets/DM-27502
branch
from
4e861df
to
68831e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.