DM-5323 #24
Merged
DM-5323 #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var = bim.getVariance(); var.set(stdev**2); del var | ||
| var = bim.getVariance() | ||
| var.set(stdev**2) | ||
| del var |
There was a problem hiding this comment.
How about just:
bim.getVariance().set(stdev**2)
r-owen
force-pushed
the
tickets/DM-5323
branch
2 times, most recently
from
d059332
to
d15b024
Compare
Fixed the following pyflake warnings in library and test code: - delete trailing whitespace - foo ==/!= None -> foo is/is not None - stop using from foo import * - stop importing unused modules - do not have multiple statements on one line
Use enumerate in one instance and simpler code to set image and variance planes of images in a few other cases.
r-owen
force-pushed
the
tickets/DM-5323
branch
2 times, most recently
from
6f9f24c
to
00572f3
Compare
r-owen
force-pushed
the
tickets/DM-5323
branch
2 times, most recently
from
3d451a0
to
c1f1ae4
Compare
Combine the functions getBackground and estimateBackground into a single task SubtractBackground with two methods: - fitBackground: fit a background model; replaces getBackground - run: fit and subtract background; replaces estimateBackground Update the other code in this package accordingly
Make SubtractBackground.fitBackground raise RuntimeError instead of returning None, unlike the getBackground function it replaces.
Change the display code to use afw.display instead of afw.ds9
In the old code SubtractConfig.validate would automatically change algorithm=None to "None". This seemed a strange thing to do, and not a very good way to do it. Instead drop support for None.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.