DM-30445: Add optional Archive element to stamps #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonKrughoff
approved these changes
Jun 8, 2021
| metadata = PropertyList() | ||
| metadata['RA_DEG'] = ras | ||
| metadata['DEC_DEG'] = decs | ||
|
|
||
| return stamps.Stamps(stamp_list, metadata=metadata) | ||
| return stamps.Stamps(stamp_list, metadata=metadata, use_archive=True) |
There was a problem hiding this comment.
I think we also need a test that uses the default of use_archive=False. I don't think we necessarily need a duplicate test for True and False for all tests, but maybe test with the default in most tests and have a specific test that uses True?
This avoids having to pass on each archive_element separately; I think it might also prove more practical again in the future to have writeFits have access to the full Stamps objects.
MorganSchmitz
force-pushed
the
tickets/DM-30445
branch
from
0bcfaf7
to
abc72c5
Compare
MorganSchmitz
force-pushed
the
tickets/DM-30445
branch
from
abc72c5
to
086c2ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket
Jenkins run 34358