Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-30902: Numpydoc conversion of meas_algorithms through stamps.py #248

Merged
merged 1 commit into from Jul 16, 2021
Merged

DM-30902: Numpydoc conversion of meas_algorithms through stamps.py #248

merged 1 commit into from Jul 16, 2021

Conversation

squisty
Copy link
Contributor

@squisty squisty commented Jul 9, 2021

No description provided.

parejkoj
parejkoj requested changes Jul 10, 2021
View reviewed changes
Copy link
Contributor

@parejkoj parejkoj left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this class docstring to SkyObjectsTask:

Generate a list of Footprints of sky objects.

Yes, it duplicates the first sentence of run, but this ensures there is a useful sentence in the Task Reference section.

doc/lsst.meas.algorithms/tasks/lsst.meas.algorithms.ReferenceSourceSelectorTask.rst Outdated
ReferenceSourceSelectorTask
###########################

``ReferenceSourceSelectorTask`` selects reference sources by optionally applying a magnitude limit, flag requiremnts and color limits.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"requirements"

doc/lsst.meas.algorithms/tasks/lsst.meas.algorithms.ScienceSourceSelectorTask.rst Outdated
ScienceSourceSelectorTask
#########################

``ScienceSourceSelectorTask`` selects sources from images being processed by optionally applying magnitude limits, flag requiremens and star/galaxy separation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"requirements"

parejkoj
parejkoj approved these changes Jul 16, 2021
View reviewed changes
Copy link
Contributor

@parejkoj parejkoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@squisty squisty force-pushed the tickets/DM-30902 branch 2 times, most recently from 3747d66 to 435de27 Compare July 16, 2021 22:36
@squisty squisty merged commit 996ca24 into master Jul 16, 2021
@squisty squisty deleted the tickets/DM-30902 branch July 16, 2021 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parejkoj parejkoj parejkoj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@squisty @parejkoj