DM-35105 Force (0, 0) for center of warped PSF images. #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktlim
reviewed
Jun 6, 2022
Previous logic forced the image size to be odd, but picked the center of the kernel image bbox based on center of the transformed kernel image bbox. But the output kernel image center is an input: (0, 0). This manifested as even-sizes images later in CoaddPsf; the union of two odd-sized boxes with the same dimensions but offset center is an even-sized box.
TallJimbo
force-pushed
the
tickets/DM-35105
branch
from
fa6216e
to
3603d2d
Compare
fred3m
approved these changes
Jun 6, 2022
| geom::Extent2I out_half_dims = geom::floor(0.5*out_box_fp.getDimensions()); | ||
| geom::Box2I out_box; | ||
| geom::Point2I out_center(out_box_fp.getCenter()); | ||
| geom::Point2I out_center(0, 0); | ||
| out_box.include(out_center); |
There was a problem hiding this comment.
Any reason that you decided to define out_box this way instead of using out_box = Box2I(Point2I(0,0), Extent2I(1,1))?
There was a problem hiding this comment.
Not really; it just fit my mental model of what I was doing better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous logic forced the image size to be odd, but picked the center of the kernel image bbox based on center of the transformed kernel image bbox. But the output kernel image center is an input: (0, 0).
This manifested as even-sizes images later in CoaddPsf; the union of two odd-sized boxes with the same dimensions but offset center is an even-sized box.