Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-35870: Enable PSF padding by default in computeApertureFlux #292

Merged
merged 2 commits into from Sep 1, 2022
Merged

DM-35870: Enable PSF padding by default in computeApertureFlux #292

merged 2 commits into from Sep 1, 2022

Conversation

leeskelvin
Copy link
Contributor

No description provided.

@leeskelvin leeskelvin force-pushed the tickets/DM-35870 branch 2 times, most recently from 06edb43 to 4606600 Compare September 1, 2022 17:07
fred3m
fred3m approved these changes Sep 1, 2022
View reviewed changes
Copy link

@fred3m fred3m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I wasn't aware of being able to update an image using assign, that's a neat trick! I think I'll update the multi-band version in meas_extensions_scarlet at some point.

@leeskelvin
Copy link
Contributor Author

Thanks Fred. Re: assign, full credit to @TallJimbo and @erykoff for pair coding this with me yesterday!

@leeskelvin leeskelvin merged commit 7bc907a into main Sep 1, 2022
@leeskelvin leeskelvin deleted the tickets/DM-35870 branch September 1, 2022 20:50
@leeskelvin leeskelvin changed the title DM-34253: Enable PSF padding by default in computeApertureFlux DM-35870: Enable PSF padding by default in computeApertureFlux Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fred3m fred3m fred3m approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@leeskelvin @fred3m