DM-36071: Deprecate kernelSize* parameters in PSF determiner tasks #296
Conversation
arunkannawadi
force-pushed
the
tickets/DM-36071
branch
4 times, most recently
from
6e2227d
to
a3e7aed
Compare
There was a problem hiding this comment.
Looks good, though I suspect it might be better to squash some commits, just given the number of commits to the number of actual lines changed overall.
If you don't squash, you've got one commit message with a typo, in which the actual word "typo" should be "type".
| ) | ||
|
|
||
| def validate(self): | ||
| # TODO: DM-36311: This entire method may be removed after v25. |
There was a problem hiding this comment.
Might be better to be specific about which lines are to be removed, on the off chance something else gets added to this method before that ticket happens.
| @@ -34,22 +34,51 @@ class BasePsfDeterminerConfig(pexConfig.Config): | |||
|
|
|||
| This is fairly sparse; more fields can be moved here once it is clear they are universal. | |||
| """ | |||
| stampSize = pexConfig.Field( | |||
There was a problem hiding this comment.
I see you used the new type annotation syntax elsewhere on this PR, but not here. Any reason why? (I don't have a preference, except for consistency.)
There was a problem hiding this comment.
I did that in one file, where there were only two config fields. I'm happy to change it in the files I'm touching.
arunkannawadi
force-pushed
the
tickets/DM-36071
branch
from
a3e7aed
to
2d0f887
Compare
arunkannawadi
force-pushed
the
tickets/DM-36071
branch
from
2d0f887
to
caa1230
Compare
|
Squashed some commits (reduced 19 to 10) and added one more. |
No description provided.