meas_algorithms Review for DM-420 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 15, 2015 14:55
…lgorithms DM-420 changes to retained files for removal of measurement
…algorithms Remove examples, most of which were specifically for meas_algorithms measurement. growthcurve.py will be moved to meas_base, keep only measAlgTasks.py Delete tests which should be in meas_base. Fix tests which remained in meas_algorithms so that they would run with meas_base.
| sys.exit(1) | ||
| #if not mypath: | ||
| # print >> sys.stderr, "Please setup afwdata and try again" | ||
| # sys.exit(1) |
There was a problem hiding this comment.
Please uncomment these lines.
|
I noticed here that you've actually made commits as two different people on this branch, probably because you have different email addresses configured with git on different machines and/or you haven't told GitHub about all of them. It's not worth changing for this issue, but you might want to look into updating that at some point, especially if the email address for one of them (pgee@pgeepc2.physics.ucdavis.edu) isn't actually an email address. It's probably your |
Other fixes for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.