New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-37102: convertGaiaXpManager added #300
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: the PR needs to include the ticket number; see:
https://developer.lsst.io/work/flow.html#make-a-pull-request
Also, the linter failed: that will have to be fixed before merging.
inFluxKey=item.replace('_','_flux_') | ||
outFluxKey=item + '_flux' | ||
|
||
inFluxErrKey=item.replace('_','_flux_error_') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this for? The mag_column_list
should have the actual name of the input fields, I would think. What are the names of the input flux fields in the xpSpec files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Example xp photometry column names are:
'Lsst_flux_u',
'Lsst_flux_error_u'
I had thought we would want output to be:
'Lsst_u_flux' or 'Lsst_u_fluxErr'
But instead we want to preserve the original column name the fluxes come from in the xp catalog so output will be
'Lsst_flux_u_flux' or 'Lsst_flux_u_fluxErr'
824d037
to
6f54eee
Compare
6f54eee
to
f0c8b88
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, this looks better.
Though, note the missing colon in the PR title.
No description provided.