Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-37102: convertGaiaXpManager added #300

Merged
merged 1 commit into from Nov 30, 2022
Merged

DM-37102: convertGaiaXpManager added #300

merged 1 commit into from Nov 30, 2022

Conversation

psferguson
Copy link
Contributor

No description provided.

Copy link
Contributor

@parejkoj parejkoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: the PR needs to include the ticket number; see:

https://developer.lsst.io/work/flow.html#make-a-pull-request

Also, the linter failed: that will have to be fixed before merging.

python/lsst/meas/algorithms/convertRefcatManager.py Outdated Show resolved Hide resolved
python/lsst/meas/algorithms/convertRefcatManager.py Outdated Show resolved Hide resolved
inFluxKey=item.replace('_','_flux_')
outFluxKey=item + '_flux'

inFluxErrKey=item.replace('_','_flux_error_')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this for? The mag_column_list should have the actual name of the input fields, I would think. What are the names of the input flux fields in the xpSpec files?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example xp photometry column names are:
'Lsst_flux_u',
'Lsst_flux_error_u'
I had thought we would want output to be:
'Lsst_u_flux' or 'Lsst_u_fluxErr'
But instead we want to preserve the original column name the fluxes come from in the xp catalog so output will be
'Lsst_flux_u_flux' or 'Lsst_flux_u_fluxErr'

python/lsst/meas/algorithms/convertRefcatManager.py Outdated Show resolved Hide resolved
python/lsst/meas/algorithms/convertRefcatManager.py Outdated Show resolved Hide resolved
@psferguson psferguson changed the title convertGaiaXpManager added DM-37102 convertGaiaXpManager added Nov 28, 2022
@psferguson psferguson marked this pull request as draft November 28, 2022 21:41
@psferguson psferguson marked this pull request as ready for review November 28, 2022 22:35
Copy link
Contributor

@parejkoj parejkoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this looks better.

Though, note the missing colon in the PR title.

@psferguson psferguson changed the title DM-37102 convertGaiaXpManager added DM-37102: convertGaiaXpManager added Nov 30, 2022
@psferguson psferguson merged commit 18b29b1 into main Nov 30, 2022
@psferguson psferguson deleted the tickets/DM-37102 branch November 30, 2022 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants