Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-37415: Add debugging log output of filenames to convertRefcat #304

Merged
merged 1 commit into from Dec 21, 2022
Merged

DM-37415: Add debugging log output of filenames to convertRefcat #304

merged 1 commit into from Dec 21, 2022

Conversation

parejkoj
Copy link
Contributor

No description provided.

@parejkoj
Add logging of files and add information for exceptions
52ab3f7 
Exceptions within multiprocessing are not informative about which file
triggered the problem. Catching, logging info, and re-raising should
help.
psferguson
psferguson approved these changes Dec 21, 2022
View reviewed changes
Copy link
Contributor

@psferguson psferguson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was very useful for identifying the catalog files that were failing the conversion.

@parejkoj parejkoj merged commit e3a8c49 into main Dec 21, 2022
@parejkoj parejkoj deleted the tickets/DM-37415 branch December 21, 2022 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psferguson psferguson psferguson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@parejkoj @psferguson