DM-37955: Update measureApCorrTask to use robust median outlier rejection. #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
approved these changes
Mar 3, 2023
| self.used = schema.addField("apcorr_" + name + "_used", type="Flag", | ||
| doc="set if source was used in measuring aperture correction") | ||
| self.fluxName = name + "_instFlux" | ||
| if not schema.extract(self.fluxName): |
There was a problem hiding this comment.
if self.fluxName not in schema: is more idiomatic, and I sure hope it's not slower.
| for iteration in range(self.config.numIter): | ||
| resid = z - fitValues | ||
| # We allow floating-point slop to allow for field estimation | ||
| # noise in a completely flat field. |
There was a problem hiding this comment.
Does this avoid a divide-by-zero somewhere? I think that means a slightly longer comment here would be useful.
There was a problem hiding this comment.
I don't think so, but I've rephrased the comment to be clear this shows up in tests when the residual field is completely flat and median_abs_deviation doesn't return identically zero in that case.
tests/test_measureApCorr.py
Outdated
| with self.assertRaisesRegex(RuntimeError, "only 4 sources remain"): | ||
| self.meas_apCorr_task.run(catalog=sourceCat, exposure=self.exposure) | ||
|
|
||
| # With the measurement algorithm declared as something that might fail, should not get an exception |
There was a problem hiding this comment.
Something in this sentence seems awry.
There was a problem hiding this comment.
I copied it from another test, but I have rephrased both of them to be clearer.
erykoff
force-pushed
the
tickets/DM-37955
branch
from
91a08cd
to
82353a0
Compare
This replaces the default source selector to use all possible (unflagged) stars, and additional checks on the fit degree after outlier rejection.
erykoff
force-pushed
the
tickets/DM-37955
branch
from
82353a0
to
4c50365
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the default source selector to use all possible (unflagged) stars, and additional checks on the fit degree after outlier rejection.