Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-37468: Remove fpSets from SourceDetectionTask.run() plus cleanup #310

Merged
merged 1 commit into from
Mar 6, 2023
Merged

DM-37468: Remove fpSets from SourceDetectionTask.run() plus cleanup #310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions doc/lsst.meas.algorithms/tasks/lsst.meas.algorithms.SourceDetectionTask.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,8 @@ We can then unpack the results:
.. code-block:: py

sources = result.sources
print("Found %d sources (%d +ve, %d -ve)" % (len(sources), result.fpSets.numPos,
result.fpSets.numNeg))
print("Found %d sources (%d +ve, %d -ve)" % (len(sources), result.numPos,
result.numNeg))

.. _lsst.meas.algorithms.SourceDetectionTask-debug:

Expand Down
1 change: 0 additions & 1 deletion python/lsst/meas/algorithms/detection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,6 @@ def run(self, table, exposure, doSmooth=True, sigma=None, clearMask=True, expId=
record.set(self.negativeFlagKey, True)
if results.positive:
results.positive.makeSources(sources)
results.fpSets = results.copy() # Backward compatibility
results.sources = sources
return results

Expand Down
5 changes: 2 additions & 3 deletions tests/test_negative.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,11 +86,10 @@ def test_detection_stdev(self):
table = afwTable.SourceTable.make(schema)
detections = detection.run(table, exposure)
sources = detections.sources
fpSets = detections.fpSets

self.assertEqual(len(sources), numX*numY)
self.assertEqual(fpSets.numPos, numX*numY/2)
self.assertEqual(fpSets.numNeg, numX*numY/2)
self.assertEqual(detections.numPos, numX*numY/2)
self.assertEqual(detections.numNeg, numX*numY/2)

measurement.run(sources, exposure)

Expand Down