Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-38753: Use InMemoryDatasetHandle for mock ref cat handle #316

Merged
merged 2 commits into from Apr 21, 2023
Merged

DM-38753: Use InMemoryDatasetHandle for mock ref cat handle #316

merged 2 commits into from Apr 21, 2023

Conversation

timj
Copy link
Member

@timj timj commented Apr 19, 2023

No description provided.

@timj
Copy link
Member Author

timj commented Apr 19, 2023 •
edited

Classes similar to MockRefcatDataId are defined in a couple of tests in analysis_tools and drp_tasks. In theory we could modify the version here so it just takes a region and then change the other packages so they use the one from here. Not entirely sure it's worth it but I'm happy to make the change.

This was referenced Apr 20, 2023
Merged
Merged
@timj timj merged commit 691b785 into main Apr 21, 2023
1 check passed
@timj timj deleted the tickets/DM-38753 branch April 21, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erykoff erykoff erykoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@timj @erykoff