Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-39712: Use introspection to read the correct MaskedImage stamp type #337

Merged
merged 3 commits into from
Jun 22, 2023

Commits on Jun 21, 2023

  1. Force stamps to be ImageF

    This allows guider files of type ImageI to be read in.
    This does not solve the problem of ImageD stamps though.
    
    The Stamps abstract class doesn't force MaskedImageF but
    the main Stamps definition does.
    
    If Guider files declared a different type of Stamps
    class rather than the default then we could relax
    this constraint on the reader.
    timj committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    c994da4 View commit details
    Browse the repository at this point in the history
  2. Use introspection to always create a stamp with the correct MaskedImage

    The stamp_factory is associated with a Stamp class that has a
    MaskedImage field. Use that field to work out the class that
    the fits reader should be using and the associated data
    type.
    timj committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    70a6745 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2023

  1. Configuration menu
    Copy the full SHA
    f3d1d2f View commit details
    Browse the repository at this point in the history