Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-5877: Use Afterburners to clean up aperture correction logic #34

Merged
merged 2 commits into from Jul 5, 2016
Merged

DM-5877: Use Afterburners to clean up aperture correction logic #34

merged 2 commits into from Jul 5, 2016

Conversation

PaulPrice
Copy link
Contributor

No description provided.

@PaulPrice
Copy link
Contributor Author

Please explain in the first commit what has changed in meas_base that necessitates this patch.

@natelust natelust force-pushed the tickets/DM-5877 branch 2 times, most recently from ac877a2 to d870e2a Compare June 22, 2016 21:02
@natelust
Remove apcorr config from SingleFrameMeasurementTask instance
493b87e 
Applying aperture corrections has been moved out of the single frame
measurement task, and moved to be a sister task wherever
SingleFrameMeasurementTask is used. The configuration for aperture
corrections is thus within that task and not SFM
@natelust
Remove classification plugin from config object
bbdd5d0 
Classification now happens in the afterburner task, not a measurement
task, and thus the configuration needs to be modified. Introducing
an afterburner task is unneeded as the tests did not actually test
any functionality that depended on classification.
@natelust natelust merged commit bbdd5d0 into master Jul 5, 2016
@ktlim ktlim deleted the tickets/DM-5877 branch August 25, 2018 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@PaulPrice @natelust