Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-40186: Update dynamic detection task defaults and logging #349

Merged
merged 4 commits into from
Aug 16, 2023
Merged

DM-40186: Update dynamic detection task defaults and logging #349

merged 4 commits into from
Aug 16, 2023

Commits on Aug 15, 2023

  1. Remove INTRP from avoid list in dynamic detection 

    As the number of input visits increases, the number of pixels with the
INTRP mask bit set increases, which eventually leads to a very large
fraction pixels with this mask bit set.  Thus, if INTRP is included in
the list of masks to avoid when laying down sky objects, very deep
coadds will end up with little-to-no available locations for sky
objects, leading to a failure in the dynamic detection.  Thus, the
safest thing to do is leave it out of the masks to avoid list.
    @laurenam
    laurenam committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    f8164e5 View commit details
    Browse the repository at this point in the history

  2. Reduce the fraction of sky sources for bg tweak

    @laurenam
    laurenam committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    552e40f View commit details
    Browse the repository at this point in the history

  3. Fix parameter name in docstring

    @laurenam
    laurenam committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    c6e57d0 View commit details
    Browse the repository at this point in the history

  4. Add and use information about fraction of good pix 

    In the dynamic detection task, compute and log the number of "good"
pixels in the exposure, where "good" is defined simply as not having
either the NO_DATA or BAD mask bit set.  If this fraction is greater
than 20% of the total number of pixels, yet we still fail to locate
enough spots to lay down sky objects, raise an RuntimeError exception.
The message includes the fraction of the "good" pixels marked either
DETECTED or DETECTED_NEGATIVE as this is a likely reason for this
situation.
    @laurenam
    laurenam committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    48b8a4b View commit details
    Browse the repository at this point in the history