Tickets/dm 6969 #41
Merged
Tickets/dm 6969 #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-owen
force-pushed
the
tickets/DM-6969
branch
2 times, most recently
from
f291fc2
to
fc933cf
Compare
Fixed outdated schema documentation in LoadReferenceObjectsTask: - <filterName>_camFlux[Sigma] instead of <filterName>_camera_flux[Sigma] - camFlux[Sigma] instead of default_flux[Sigma] Fixed reported return type of loadPixelBox from a ref catalog to a struct containing refCat and fluxField
...into namespace lsst.meas.algorithms, for easier access
Changed LoadIndexedReferenceObjectConfig to inherit from LoadReferenceObjectsConfig instead of Config, since parts of the standard loader need those fields.
Test that cls.comp_cats includes at least one non-empty catalog Document cls.comp_cats Use cls.comp_cats.iter_items() to avoid messy lookups
Add flux aliases to reference catalog returned by LoadIndexedReferenceObjectsTask
HtmIndexerTask used ctrCoord.getRa and getDec, which are not reliably present, depending on whether the object is passed in as a Coord or a subclass (even if ctrCoord is actually a pointer to an Fk5Coord or IcrsCoord, it may show up as a pointer to Coord). So use getLongitude and getLatitude, instead.
Make sure the catalog returned by LoadIndexedReferenceObjectsTask is contiguous (formerly it was not if loaded from multiple trixels)
Add missing "centroid" and "hasCentroid" fields to the catalog
returned by LoadIndexedReferenceObjectsTask. These are initialized
to ("nan", "nan"), and False, respectively
We usually make both the task and its config available in __all__ Also fix the name: LoadIndexedReferenceObjectsConfig instead of LoadIndexedReferenceObjectConfig
Fix documentation of LoadIndexedReferenceObjectsTask.loadSkyCircle to say that an empty catalog is returned (rather than None) if no sources found. Update tests/testHtmIndex.py accordingly.
Changed search_radius to an angle to simplify tests/testHtmIndex.py and added some missing doc strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.