DM-6999: Logging framework migration #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsinfang
force-pushed
the
tickets/DM-6999
branch
from
d629d81
to
bd188ec
Compare
hsinfang
force-pushed
the
tickets/DM-6999
branch
4 times, most recently
from
f9a1085
to
d2dfac3
Compare
This old trace/debug level of 1 was used as a warning. Replace it and log it to the WARN level.
hsinfang
force-pushed
the
tickets/DM-6999
branch
from
d2dfac3
to
15f66c9
Compare
added 2 commits
September 1, 2016 14:18
With the logging framework changes in pipe_base, Tasks' logs is transitioned from pex.logging to lsst.log. This commit handles the API changes from the framework changes and other individual usages. lsst.pex.logging logdebug is replaced with lsst.log at DEBUG level. In pcaPsfDeterminer.py, two debug levels are used: log.log(-2, ...) is replaced by log.debug() log.log(-3, ...) is replaced by log.trace()
Based on this commit: 4f0d38a the records logged at pex.logging debug(2) are meant to be logged to a level more verbose than a typical debug level, hence they are logged to TRACE with lsst.log.
hsinfang
force-pushed
the
tickets/DM-6999
branch
from
b969efb
to
e078dd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.