DM-7180: Port HSC Aperture Correction Fix #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| self.log.info("Measuring aperture corrections for %d flux fields" % (len(self.toCorrect),)) | ||
| # First, create a subset of the catalog that contains only selected stars | ||
| # with non-flagged reference fluxes. | ||
| subset1 = [record for record in self.starSelector.selectStars(exposure, catalog).starCat | ||
| if not record.get(self.refFluxKeys.flag)] | ||
| if not record.get(self.refFluxKeys.flag) and | ||
| numpy.isfinite(record.get(self.refFluxKeys.flux))] |
There was a problem hiding this comment.
Please indent a bit here so that it's obvious that it's not a new statement. The if aligned with the numpy confuses a quick scan of the code.
A single NAN in the inputs can produce all-NAN outputs, so be careful to get them all.
Zero flux in the measurement being corrected will cause a ZeroDivisionError which can bring everything down, so we need to catch this case.
PaulPrice
force-pushed
the
tickets/DM-7180
branch
from
5a92e76
to
40e6f29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.