tickets/DM-7248 #44
Merged
tickets/DM-7248 #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several tests in meas_algorithms were named improperly i.e. did not begin with test etc.. This commit renames all of those tests to the standard naming convention i.e. prepends a 'test' in front of the name and capitalizes the former first character.
AstroVPK
force-pushed
the
tickets/DM-7248
branch
from
c9ea3d5
to
574455a
Compare
isullivan
force-pushed
the
tickets/DM-7248
branch
2 times, most recently
from
0b9289a
to
c269e01
Compare
| class UtilsBinaryTester(lsst.utils.tests.ExecutablesTestCase): | ||
| pass | ||
|
|
||
| EXECUTABLES = ['testPsfAttributes', 'testSizeMagnitudeStarSelector', 'testImagePsf', 'testPsfCaching', 'testWarpedPsf'] |
There was a problem hiding this comment.
Is this necessary? I thought it found all binaries by default.
There was a problem hiding this comment.
I didn't know it did that! It is great if it does that. I can check and revert to the default if that's true...
There was a problem hiding this comment.
It will auto detect. If you give a list then it will report if the test executable can't be found (maybe it wasn't built). If you don't give a list it will only test what it can find.
meas_algorithms has several executable tests that were formerly being run by the SCons build system. This commit makes these tests runnable via py.test by adding them to the testExecutables script.
Most tests in meas_algorithms needed updating (performed in this commit) to make them runable under the py.test framework. At the same time, the test code has been cleaned up with the usage of assert_, assertEquals removed and instances of assertTrue/False replaced with more specific equivalents when possible. Finally, the actual formatting of the code has been revised to meet the LSST PEP8 standard using autopep8.
AstroVPK
force-pushed
the
tickets/DM-7248
branch
from
c269e01
to
f9d6802
Compare
…and modernize to python 2
AstroVPK
force-pushed
the
tickets/DM-7248
branch
from
f9d6802
to
ea4d154
Compare
| @@ -24,8 +24,8 @@ python/lsst/meas/algorithms/version.py | |||
| tests/.tests | |||
| tests/data/psf*.* | |||
| tests/photometry | |||
| tests/psfAttributes | |||
There was a problem hiding this comment.
Looks like tests/photometry can be removed.
Stop setting a few unused variables. Remove a line that computed an unused string. Remove a bit of commented-out code.
| @@ -30,21 +32,20 @@ | |||
|
|
|||
| import numpy as np | |||
|
|
|||
| import lsst.utils | |||
| import lsst.afw.table as afwTable | |||
| import lsst.afw.geom as afwGeom | |||
| import lsst.afw.coord as afwCoord | |||
| import lsst.daf.persistence as dafPersist | |||
| from lsst.meas.algorithms import IngestIndexedReferenceTask, LoadIndexedReferenceObjectsTask, \ | |||
| LoadIndexedReferenceObjectsConfig, getRefFluxField | |||
There was a problem hiding this comment.
Clean up the unittest code and remove some extra whitespace. Get path to data via __file__. Remove extra file in .gitignor. Move random seed initializer into setup.
AstroVPK
force-pushed
the
tickets/DM-7248
branch
from
eb5e9c1
to
b735ab1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.