meas_algorithms/DM-8147: Add backwards compatibility to CoaddPsf input. #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktlim
reviewed
Nov 1, 2016
| CoaddPsfPersistenceHelper const & keys1 = CoaddPsfPersistenceHelper::get(); | ||
| LSST_ARCHIVE_ASSERT(catalogs.size() == 2u); |
There was a problem hiding this comment.
Can't you keep this now that you have the check above?
TallJimbo
force-pushed
the
tickets/DM-8147
branch
from
368a2d4
to
ffc5754
Compare
r-owen
approved these changes
Nov 2, 2016
| @@ -354,8 +354,11 @@ class CoaddPsf::Factory : public tbl::io::PersistableFactory { | |||
|
|
|||
| virtual PTR(tbl::io::Persistable) | |||
| read(InputArchive const & archive, CatalogVector const & catalogs) const { | |||
| CoaddPsfPersistenceHelper const & keys1 = CoaddPsfPersistenceHelper::get(); | |||
| if (catalogs.size() == 1u) { | |||
There was a problem hiding this comment.
Please explain this test (why does catalogs.size() tell us the catalog version) in a code comment.
This adds support for reading very old Exposures with CoaddPsfs written before 7/10/2013. It will not in general preserve the PSF's "average position" exactly, which is used when no position is provided to the PSF, because the information needed to reconstruct that has already been lost.
TallJimbo
force-pushed
the
tickets/DM-8147
branch
from
ffc5754
to
0b4b4df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for reading very old Exposures with CoaddPsfs written before 7/10/2013. It will not in general preserve the PSF's "average position" exactly, which is used when no position is provided to the PSF, because the information needed to reconstruct that has already been lost.