DM-8088: When making PSF-matched coadds, warp first then PSF-match #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increase unit test coverage by adding SingleGaussianPsf tests to testDoubleGaussianPsf and renaming to testGaussianPsf.
PSF-matching a WarpedPsf to a model PSF requires the ability to change the kernel dimensions of model PSFs at runtime depending on the maximum (or minimum) dimensions of a WarpedPsf across an image. Because PSFs are immutable, resized() produces a copy of itself with same model parameters and specified new dimensions.
|
Looks good @yalsayyad . No comments on this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.