Review for DM-8714: Add unittest for base_SdssShape_psf measurement #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdswinbank
commented
Dec 22, 2016
| exposure, catalog = self._runMeasurementTask(psf=varyingPsf) | ||
| key = measBase.SdssShapeResultKey(catalog.schema["base_SdssShape"]) | ||
| for record in catalog: | ||
| psfTruth = exposure.getPsf().computeShape(afwGeom.Point2D(record.getX(), record.getY())) |
There was a problem hiding this comment.
I have absolute faith that the PSF really is varying exactly as you say it is.
But.. what if it wasn't? If we screwed up and varyingPsf was actually constant across the image, then this test would pass even if the original bug was still in SdssShape.
I grant it's unlikely, but could we add an extra assertion here to establish that psfTruth really does vary by record?
This test is being added here in meas_algorithms rather than meas_base (where SdssShape lives) due to the need to apply a spatially varying PSF model such that the PSF is different at each position in the image. This varying psf model is built with meas_algorithms' PcaPsf (which is not accessible from meas_base).
laurenam
force-pushed
the
tickets/DM-8714
branch
from
f8d5f34
to
e8fbbba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is being added here in meas_algorithms rather than meas_base
(where SdssShape lives) due to the need to apply a spatially varying
psf model such that the psf is different at each position in the image.
This varying psf model is built with meas_algorithms' PcaPsf (which is
not accessible from meas_base).