Make loader agnostic to ingest name #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulPrice
approved these changes
Jan 20, 2017
| # test that a catalog can be loaded even with a name not used for ingestion | ||
| butler = dafPersist.Butler(self.test_repo_path) | ||
| config = LoadIndexedReferenceObjectsConfig() | ||
| config.ref_dataset_name = "diff_ref_name" |
There was a problem hiding this comment.
This is a magic string used in multiple places. Can you consolidate them into a single variable?
There was a problem hiding this comment.
Good point. Done.
| loader = LoadIndexedReferenceObjectsTask(butler=butler, config=config) | ||
| # This location is known to have objects | ||
| tupl = (93.0, -90.0) | ||
| cent = make_coord(*tupl) |
There was a problem hiding this comment.
Is there a reason not to strip out the tupl variable and just to make_coord(93.0, -90.0)?
There was a problem hiding this comment.
Another good point. I also consolidated so I don't define cent twice.
There was a problem hiding this comment.
Saves me from moaning that tupl is a terrible name for a variable 😉
SimonKrughoff
force-pushed
the
tickets/DM-9041
branch
from
ab0beec
to
d3ca5ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.