Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tickets/dm 9828 #72

Merged
merged 3 commits into from
Mar 31, 2017
Merged

Tickets/dm 9828 #72

merged 3 commits into from
Mar 31, 2017

Commits on Mar 30, 2017

  1. Enable rectangular bins in SubtractBackgroundTask 

    Add config parameters binSizeX and binSizeY which control
the bin size in the x and y dimensions individually.
If either is 0, the default, the general binSize parameter
is used for the bin size in that dimension.
Applies to both polynomial and spline background models.
    @yalsayyad
    yalsayyad committed Mar 30, 2017
    Configuration menu
    Copy the full SHA
    7f98683 View commit details
    Browse the repository at this point in the history

  2. Validate polynomial order with order variable rather than mix 

    of order and config.approxOrderX in the undersampling check in
SubtractBackgroundTask. This change does not alter
behavior because the order is assigned config.approxOrderX.
    @yalsayyad
    yalsayyad committed Mar 30, 2017
    Configuration menu
    Copy the full SHA
    a6ad6ff View commit details
    Browse the repository at this point in the history

  3. Change default spline type to Akima in SubtractBackgroundTask 

    Chebyshev polynomials are the default background model,
but when splines are requested, the default interpolation
style should be the more stable and robust AKIMA_SPLINE,
to be consistent with other background subtraction classes
and documentation.
    @yalsayyad
    yalsayyad committed Mar 30, 2017
    Configuration menu
    Copy the full SHA
    c795208 View commit details
    Browse the repository at this point in the history