DM-9192 add == and toString for new BoundedField API #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
force-pushed
the
tickets/DM-9192
branch
5 times, most recently
from
00b6a7e
to
f1a1951
Compare
TallJimbo
reviewed
Apr 28, 2017
src/CoaddBoundedField.cc
Outdated
| } | ||
| catch (std::bad_cast&) { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
I'd recommend converting the try block to:
auto rhsCasted = dynamic_cast<CoaddBoundedfield const *>(&rhs);
if (!rhsCasted) {
return false;
}
...
Some (most?) compilers make checking for nullptr much faster than throwing and catching an exception, so when you don't actually gain anything from exceptions (e.g. unwinding the stack gracefully) it's better to use the pointer form of dynamic_cast.
There was a problem hiding this comment.
Thanks for the suggestion. I've implemented this here, and done the same for ChebyshevBoundedField.
parejkoj
force-pushed
the
tickets/DM-9192
branch
from
022f87f
to
148a2b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were added to the Boundedfield API as part of the work on PhotoCalib.