Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-2891: Fixing showPsfMosaic and adding some tests #79

Merged
merged 1 commit into from May 31, 2019
Merged

DM-2891: Fixing showPsfMosaic and adding some tests #79

merged 1 commit into from May 31, 2019

Conversation

timothydmorton
Copy link
Contributor

@timothydmorton timothydmorton commented May 26, 2017 •
edited

The original complaint in the ticket was already satisfied, but it turned out there were a few other things that needed to be fixed up with this. And then I added minimal testing for both showPsfMosaic and showPsf.

@PaulPrice PaulPrice changed the title Fixing showPsfMosaic and adding some tests DM-2891 : Fixing showPsfMosaic and adding some tests May 26, 2017
@timothydmorton timothydmorton changed the title DM-2891 : Fixing showPsfMosaic and adding some tests tickets/DM-2891 : Fixing showPsfMosaic and adding some tests May 26, 2017
@timothydmorton timothydmorton changed the title tickets/DM-2891 : Fixing showPsfMosaic and adding some tests Fixing showPsfMosaic and adding some tests May 26, 2017
@timothydmorton timothydmorton changed the title Fixing showPsfMosaic and adding some tests DM-2891: Fixing showPsfMosaic and adding some tests May 26, 2017
pgee2000
pgee2000 reviewed Jun 12, 2017
View reviewed changes
Copy link
Contributor

@pgee2000 pgee2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this in the style guide, but it has nothing to do with this ticket. I'm OK with this, however.

pgee2000
pgee2000 reviewed Jun 12, 2017
View reviewed changes
Copy link
Contributor

@pgee2000 pgee2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how if "deferToFrame" works the same as the old default for showPsf. If so, this should be OK.

@yalsayyad yalsayyad merged commit e3de066 into master May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgee2000 pgee2000 pgee2000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@timothydmorton @pgee2000 @yalsayyad