New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-11023: CoaddPsf: add more exception info #83
Conversation
Two things. |
I don't see how it's possible to continue on. We could ignore the error and not include that image's |
O.K. fair point with regard to discovering astrometric problems early. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments in the general PR discussion.
OK, I just checked and I don't see an existing test of the exception. Adding one is more work than I originally signed up for, but I'll see if I can make one quickly. |
1b0e06e
to
e0e37bc
Compare
Added a test, and rebased against master. |
A common problem when calling CoaddPsf.computePsfImage() is that WarpedPsf.computeBBoxFromTransform throws a RangeError stating 'Unexpectedly large transform passed to WarpedPsf'. This is usually because the astrometry for an input is poor, but it would be nice to identify *which* input: so add the exposure ID to the exception message.
CoaddPsf throws a RangeError when one of the inputs has an unexpectedly large transform. This tests that behaviour.
e0e37bc
to
9c721e1
Compare
A common problem when calling CoaddPsf.computePsfImage() is that
WarpedPsf.computeBBoxFromTransform throws a RangeError stating
'Unexpectedly large transform passed to WarpedPsf'. This is
usually because the astrometry for an input is poor, but it would
be nice to identify which input: so add the exposure ID to the
exception message.