Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-7477: Increase mask plane size to 32 bits #84

Merged
merged 1 commit into from Jul 13, 2017
Merged

DM-7477: Increase mask plane size to 32 bits #84

merged 1 commit into from Jul 13, 2017

Conversation

natelust
Copy link
Contributor

No description provided.

@natelust
Transition to int32 for Masks
62730ba 
The transition to int32 for Masks triggered a name change for masks.
Update to the new api.
@PaulPrice PaulPrice changed the title tickets/DM-7477 DM-7477: Increase mask plane size to 32 bits Jul 11, 2017
PaulPrice
PaulPrice approved these changes Jul 11, 2017
View reviewed changes
Copy link
Contributor

@PaulPrice PaulPrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whitespace changes should be split out into a separate commit.

python/lsst/meas/algorithms/secondMomentStarSelector.py
# the GNU General Public License along with this program. If not,
#
# You should have received a copy of the LSST License Statement and
# the GNU General Public License along with this program. If not,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, but put this on a separate commit.

python/lsst/meas/algorithms/subtractBackground.py
# the GNU General Public License along with this program. If not,
#
# You should have received a copy of the LSST License Statement and
# the GNU General Public License along with this program. If not,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

python/lsst/meas/algorithms/testUtils.py
# the GNU General Public License along with this program. If not,
#
# You should have received a copy of the LSST License Statement and
# the GNU General Public License along with this program. If not,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

@natelust natelust merged commit 62730ba into master Jul 13, 2017
@ktlim ktlim deleted the tickets/DM-7477 branch August 25, 2018 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaulPrice PaulPrice PaulPrice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@natelust @PaulPrice