DM-11338: CoaddPsf: add control class #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
approved these changes
Jul 21, 2017
| "Name of warping kernel; choices: lanczos3,lanczos4,lanczos5,bilinear,nearest"); | ||
| LSST_CONTROL_FIELD(cacheSize, int, "Warping kernel cache size"); | ||
|
|
||
| explicit CoaddPsfControl(std::string _warpingKernelName="lanczos3", int _cacheSize=10000) : |
There was a problem hiding this comment.
I don't believe we have an established convention for this, but in cases like this I tend to use a trailing underscore instead of a leading one. Not a big deal either way.
|
|
||
| from lsst.pex.config import makeConfigClass | ||
| makeConfigClass(CoaddPsfControl, "CoaddPsfConfig") | ||
| del makeConfigClass |
There was a problem hiding this comment.
While it's a bigger change, I think it'd be more appropriate to move this to coaddPsf/coaddPsfContinued.py (and move coaddPsf.cc to coaddPsf/coaddPsf.cc and add an __init__.py there).
And while it's unrelated, would you mind zapping the Swig cleanup code just above this block?
This allows simple configuration of CoaddPsf from python.
PaulPrice
force-pushed
the
tickets/DM-11338
branch
from
13f8791
to
9ea43e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows simple configuration of CoaddPsf from python.