DM-11356: Confusion of refObjLoader.pixelMargin and matcher.maxOffsetPix #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulPrice
force-pushed
the
tickets/DM-11356
branch
from
f60ad38
to
7dbbca9
Compare
The LoadReferenceObjectsTask is the consumer of what has been called the 'match metadata', because its 'joinMatchListWithCatalog' method reads it. Therefore, it should also produce it, so that the format can be kept consistent: encapsulation.
This values matches MatchOptimisticBConfig.maxOffsetPix .
PaulPrice
force-pushed
the
tickets/DM-11356
branch
from
7dbbca9
to
0f36432
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.