Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-11810: Use temp files for test_psfIO.py #92

Merged
merged 1 commit into from Sep 6, 2017
Merged

DM-11810: Use temp files for test_psfIO.py #92

merged 1 commit into from Sep 6, 2017

Conversation

danielsf
Copy link
Contributor

@danielsf danielsf commented Sep 5, 2017

No description provided.

@danielsf danielsf requested a review from timj September 5, 2017 23:11
timj
timj approved these changes Sep 6, 2017
View reviewed changes
Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Thank you. I don't think the unlink needs protecting as it's effectively a further test that a file did appear.

@danielsf danielsf merged commit beff679 into master Sep 6, 2017
@timj timj changed the title Tickets/dm 11810 DM-11810: Use temp files for test_psfIO.py Sep 6, 2017
@ktlim ktlim deleted the tickets/DM-11810 branch August 25, 2018 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timj timj timj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@danielsf @timj