Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-16868: Remove explicit schema variable RefMatchTask and inherited tasks. #110

Merged
merged 2 commits into from
Jan 29, 2019
Merged

DM-16868: Remove explicit schema variable RefMatchTask and inherited tasks. #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91d46c1
Remove explicit unused schema from RefMatchTask.
morriscb Jan 29, 2019
1053d3c
Remove propogating schema into RefMatchTask.
morriscb Jan 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/lsst/meas/astrom/astrometry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ class AstrometryTask(RefMatchTask):
_DefaultName = "astrometricSolver"

def __init__(self, refObjLoader, schema=None, **kwargs):
RefMatchTask.__init__(self, refObjLoader, schema=schema, **kwargs)
RefMatchTask.__init__(self, refObjLoader, **kwargs)

if schema is not None:
self.usedKey = schema.addField("calib_astrometry_used", type="Flag",
Expand Down
4 changes: 1 addition & 3 deletions python/lsst/meas/astrom/ref_match.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,15 +61,13 @@ class RefMatchTask(pipeBase.Task):
----------
refObjLoader : `lsst.meas.algorithms.ReferenceLoader`
A reference object loader object
schema : `lsst.afw.table.Schema`
ignored; available for compatibility with an older astrometry task
**kwargs
additional keyword arguments for pipe_base `lsst.pipe.base.Task`
"""
ConfigClass = RefMatchConfig
_DefaultName = "calibrationBaseClass"

def __init__(self, refObjLoader, schema=None, **kwargs):
def __init__(self, refObjLoader, **kwargs):
pipeBase.Task.__init__(self, **kwargs)
if refObjLoader:
self.refObjLoader = refObjLoader
Expand Down