DM-18643: Move AstrometryTask source selection from "matcher" into AstrometryTask #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morriscb
approved these changes
Apr 11, 2019
| self.sourceSelector.name = "matcher" | ||
| self.sourceSelector["matcher"].sourceFluxType = self.sourceFluxType | ||
|
|
||
| # Note that if the matcher is MatchOptimisticBTask, then the |
There was a problem hiding this comment.
Quick clarification: The excludePixelFlags value doesn't need to be set True for the matcher to work, this was just the previous behavior. In fact, you can get more stable behavior for the matcher in fields with many bright stars by setting this too True as most of the stars in those fields that are attempted to match with all have saturated centers.
|
Looks good. I would suggest squashing the "Fix typo" commits. |
Note that the default source and reference selectors (defined in RefMatchConfig) do not down-select, so fixing this bug will not change the default runs.
Move the sourceSelector from the match tasks into the astrometry and ref_match tasks, as per RFC-589. This will ensure that source selection is only performed once, and with a single, consistent selector. Furthermore, the reference selector is properly called in the astrometry task, rather than being skipped.
erykoff
force-pushed
the
tickets/DM-18643
branch
from
6ed4809
to
5ba83ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing RFC-589, this moves the source selector into the astrometry task, and additionally fixes the reference selector so it is run in both matching and solving modes.