Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-28258: Epoch is not getting passed consistently among reference catalog loading functions #141

Merged
merged 1 commit into from Jan 13, 2021
Merged

DM-28258: Epoch is not getting passed consistently among reference catalog loading functions #141

merged 1 commit into from Jan 13, 2021

Conversation

laurenam
Copy link
Contributor

@laurenam laurenam commented Jan 8, 2021

No description provided.

parejkoj
parejkoj approved these changes Jan 9, 2021
View reviewed changes
Copy link
Contributor

@parejkoj parejkoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine: expMd already has epoch as an astropy.Time.

It surprised me that AstrometryTask already was passing through {{epoch}} in {{solve()}}, which I think is the standard WCS codepath, so why epoch wasn't being applied already I don't fully understand.

@laurenam
Copy link
Contributor Author

laurenam commented Jan 9, 2021

AstrometryTask was passing it to loadPixelBox which was NOT passing it along to loadSkyCircle which is where the correction happens...hence this ticket 😉

@laurenam laurenam merged commit 6d51c4a into master Jan 13, 2021
@laurenam laurenam deleted the tickets/DM-28258 branch January 13, 2021 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parejkoj parejkoj parejkoj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@laurenam @parejkoj