Tickets/DM-32197: Cleanup lsstDebug references in Task docs #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsmartradio
force-pushed
the
tickets/DM-32197
branch
from
29ea6ee
to
ee61a29
Compare
Update documentation to link to the lsstDebug page. Remove outdated example section from docs The example linking to PhotoCalTask is out of date and was removed.
bsmartradio
force-pushed
the
tickets/DM-32197
branch
from
ee61a29
to
56c5745
Compare
parejkoj
reviewed
Feb 3, 2023
There was a problem hiding this comment.
PR title shouldn't have "Tickets/" in it:
https://developer.lsst.io/work/flow.html#make-a-pull-request
No need to change it here, but I would have made the "remove bad examples" a separate commit, since it's not logically connected to the lsstDebug changes.
Assuming the full pipeline docs built with working links from the pages, this looks good!
|
Incorrect ticket name. The changes will be merged on the correctly named branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lsstDebug references are now linked to the lsstDebug docs rather than indirectly, as well as some minor readability edits.
Removed extra examples which were outdated in the documents and not accurate.