matchOptimisticB: correct for distortion DM-3492 #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulPrice
force-pushed
the
tickets/DM-3492
branch
2 times, most recently
from
8a9e613
to
9a5ccd3
Compare
We use the estimated distortion (in the form of a DistortedTanWcs) to correct the source positions. Both distortion-corrected source and reference sky coordinates are projected using a simple linear Wcs.
The input Wcs we've been given is a wild guess, but matching doesn't provide a Wcs we can use as our initial guess for fitting. We generate the guess Wcs from the match list and the pixel scale from the input Wcs.
We can get some rogue matches which should be rejected as part of the Wcs fitting (but that's not done in CreateWcsWithSip). To help visualise the rejection, added some plots of the residuals.
allowedNonperpDeg was converted to radians, but then compared against a number that is in degrees. Removed the radians version.
allowedNonperpDeg was converted to radians, but then compared against a number that is in degrees. Converted theta to use Angle to reduce confusion.
PaulPrice
force-pushed
the
tickets/DM-3492
branch
from
a3b200f
to
758310a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use the estimated distortion (in the form of a DistortedTanWcs)
to correct the source positions. Both distortion-corrected source
and reference sky coordinates are projected using a simple linear
Wcs, and an offset applied to bring them as close together as
possible.