DM-39796: Update task config defaults to LSST values #185
Conversation
| @@ -75,7 +75,7 @@ class AstrometryConfig(RefMatchConfig): | |||
| dtype=bool, | |||
| doc=("If True then a rough zeropoint will be computed from matched sources " | |||
| "and outliers will be rejected in the iterations."), | |||
| default=False, | |||
| default=True, | |||
There was a problem hiding this comment.
I see that this now matches the LSST value and that the corresponding config setting has been removed in obs_lsst. However, do you want to add doMagnitudeOutlierRejection=False to obs_subaru, or are you purposely changing the behavior there?
There was a problem hiding this comment.
I have overridden it in obs_subaru, as part of a commit that tries to ensure HSC processing is unchanged after this ticket. It also has a note that HSC/DRP should review those new overrides, as they are likely unnecessary.
| @@ -88,7 +88,7 @@ struct MatchOptimisticBControl { | |||
| MatchOptimisticBControl() | |||
| : refFluxField("r_flux"), | |||
| sourceFluxField("slot_ApFlux_instFlux"), | |||
| numBrightStars(100), | |||
| numBrightStars(150), | |||
There was a problem hiding this comment.
Setting all the numBrightStars defaults to 150 seems reasonable, as this is roughly in the middle of the various values here and below, and it's the obs_subaru setting, but this is changing the current LSST value. I just want to check that this is what you intend to do.
There was a problem hiding this comment.
Yes, it's unclear why LSST used a different value, and I don't think there's any obvious a priori reason to take the LSST value over the HSC one (which is likely better tested).
This was the default in obs_lsst.
This was the overridden value for multiple cameras.
parejkoj
force-pushed
the
tickets/DM-39796
branch
from
b4ab571
to
29fd858
Compare
No description provided.