DM-35784: Allow duplicate reference flux columns #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenam
approved these changes
Sep 28, 2023
| @@ -315,7 +315,6 @@ def columns_in_target(self) -> Set[str]: | |||
| columns_ref_flux = pexConfig.ListField( | |||
| dtype=str, | |||
| default=[], | |||
| listCheck=lambda x: len(set(x)) == len(x), | |||
There was a problem hiding this comment.
Commit message could use a line explaining this change.
This allows matching multiple measured fluxes against the same reference flux.
taranu
force-pushed
the
tickets/DM-35784
branch
from
aea84ba
to
0a3b8e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.