DM-40942: Switch AstrometryTask to use ScienceSourceSelector #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
force-pushed
the
tickets/DM-40942
branch
4 times, most recently
from
0f42cd5
to
543f619
Compare
leeskelvin
reviewed
Nov 10, 2023
* Configure the selector to behave like MatcherSourceSelector, for better or worse. * Update tests to add necessary fields to in-memory catalog and refactor to be more consistent about how schema and catalogs are made. * Update test catalog file to include deblend/primary fields and centroid flag, and add script that was used to make the update.
The ds9 display label should be the task name. The TAN SIP task should be named as such, not generically "fitWcs".
These have been used as the defaults for most processing for a long time.
parejkoj
force-pushed
the
tickets/DM-40942
branch
from
543f619
to
09e0e3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.