Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-42981: Convert AstrometryTask to new exception handling system #190

Merged
merged 7 commits into from
Apr 23, 2024

Commits on Apr 18, 2024

  1. Remove _getExposureMetadata()

    This was useful in the past as parts of the Exposure API were still in
    flux, but it's stable enough now that this shouldn't be necessary.
    parejkoj committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    6a49253 View commit details
    Browse the repository at this point in the history
  2. match_tolerance->matchTolerance

    This snake_case stuck out, so I fixed it.
    parejkoj committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    d2f6ad5 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. Configuration menu
    Copy the full SHA
    a124fbe View commit details
    Browse the repository at this point in the history
  2. Refactor AstrometryTask to use new exceptions

    * Rework loop to simplify logic.
    * Remove "catch all exceptions" logic, replacing with just catching
    AstrometryError (which could be raised by the fitter or matcher).
    * Remove "using previous iteration" which appears to be a hack added
    on DM-2755 to deal with problems they were having with the old matcher.
    * Remove/rename variables to hopefully reduce excessive indirection.
    * Expand tests to reflect the new exception logic.
    * Remove testWcsFailure that was based on "never raise" approach.
    parejkoj committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    8c8c87c View commit details
    Browse the repository at this point in the history
  3. Cleanup astrometry tests

    * Remove testUsedFlag and incorporate its test of calib_astrometry_used into
    the all the `doTest` calls.
    * Removed unneeded tearDown.
    * Use more standard `task` instead of `solver`.
    parejkoj committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    a619f85 View commit details
    Browse the repository at this point in the history
  4. Move matchMeta to just before return

    It is not used elsewhere, so no need for it until we're done.
    parejkoj committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    9bbef5c View commit details
    Browse the repository at this point in the history
  5. Rework what doTest checks WCS against

    Previously, AstrometryTask would pass if it just kept the WCS on the
    exposure the same: the test now starts with a "wrong" (undistorted) WCS
    and will fail if the output WCS matches the input (at least for the
    testRadial case).
    parejkoj committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    b830d46 View commit details
    Browse the repository at this point in the history