DM-5532 #24
Merged
DM-5532 #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copying the config fields is unnecessary and complicates the constructor. Clean this up before rewriting to use StarSelector
Use the standard name for bad flag fields badFlags instead of badStarPixelFlags for the catalog star selector
Make CatalogStarSelector a subclass of StarSelectorTask, append Task to the name, and change CatalogStarSelectorTask.selectStars to return a catalog of stars instead of a list of PSF candidates.
Avoid lambdas by using RangeField in CatalogStarSelectorConfig
Standardize on "badFlags" as the variable name for bad flags in the catalog star selector, to match the standard config field name.
CatalogStarSelectorTask had two redundant debug variables: display and displayTas. I removed the latter and cleaned up the debug code slightly.
|
|
||
| @section meas_astrom_catalogStarSelector_IO Invoking the Task | ||
|
|
||
| Like all star selectors, the main method is `run`. |
There was a problem hiding this comment.
Should call out the fact that this is an unusual StarSelector for which usesMatches=True, and hence that argument is required.
Add full task documentation to CatalogStarSelectorTask
|
Can one of the admins verify this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.