ANetAstrometryConfig: add alias refObjLoader #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ANetAstrometryConfig names the 'refObjLoader' as 'solver', but users (specifically, when getting the match metadata) can refer to it as 'refObjLoader'. This alias makes that work and allows us to use astrometry.net again.
| def refObjLoader(self): | ||
| """An alias, for a uniform interface with the standard AstrometryTask""" | ||
| return self.solver | ||
|
|
There was a problem hiding this comment.
I'm confused why we haven't seen this before. Is it because no one uses this class, or did you need to do something special?
There was a problem hiding this comment.
The change triggering the problem is fairly recent (about a month ago; DM-5686), and I suspect no-one has used our astrometry.net solver since that went in.
There was a problem hiding this comment.
Having looked at the code, I agree it's reasonable for now. This change can be reverted when we overhaul the way reference loading is done (e.g. pass in a reference loader to the the astrometry solver in order to support the new index loader).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ANetAstrometryConfig names the 'refObjLoader' as 'solver', but users
(specifically, when getting the match metadata) can refer to it as
'refObjLoader'. This alias makes that work and allows us to use
astrometry.net again.