Tickets/dm 6352 #36
Merged
Tickets/dm 6352 #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new HTM reference catalog based on SDSS data that roughly matches the old photocal a.net catalog.
Update testAstrometryTask.py to use the new HTM reference catalog This required a tiny increase in max allowed angular separation on the sky: from 0.0025" to 0.0026", and the actual measured value went from 0.0024" to 0.00255". I also tweaked the code to check maximum angular and pixel separation once, after reporting the measured value, instead of checking each match. I also removed a redundant computation of angular sep. for each match. for use an HTM ref cat for testAstrometryTask.py
Update testJoinMatchListWithCatalog.py to use new HMT ref catalog and AstrometryTask instead of ANetBasicAstrometryTask
tests/testMatchOptimisticB.py was setting up astrometry.net data but then ignoring it. I removed the setup.
tests/astrometry_net_data/no-tag was not being used, so removed it
tests/data/sdssrefcat/config/IngestIndexedReferenceTask.py was stuffed with unwanted imports, including at least one private astropy file. I removed all of the unneeded imports.
|
It looks like the sdssrefcat exists in both meas_astrom and pipe_tasks. It seems like that is unnecessary. Can't it just live in meas_astrom? |
|
That data appears in both packages, and is identical in both. I'm not thrilled about this duplication, but in general we prefer test data in packages to be self-contained, so that modifying test data in one package won't mysteriously break tests in other packages. And indeed both packages had duplicate a.net versions of this data (tests/astrometry_net_data/photocal). I was able to delete one of those, and the other will move to the new a.net wrapper package as part of separating moving the a.net wrapper code into its own package. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.