DM-6999: Logging framework migration #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsinfang
force-pushed
the
tickets/DM-6999
branch
from
19e917d
to
f826f46
Compare
| @@ -87,7 +87,7 @@ def getAstrom(self): | |||
|
|
|||
| conf = measAstrom.ANetBasicAstrometryConfig() | |||
| return measAstrom.ANetBasicAstrometryTask(config=conf, andConfig=andconfig,) | |||
| #logLevel=pexLog.Log.DEBUG) | |||
| #logLevel=pexLog.Log.TRACE) | |||
There was a problem hiding this comment.
I suggest you just delete this dead code, rather than updating it.
|
I had only very minor comments on the code. I don't have the new lsst.log so the changed tests all fail for me, but assuming that they do all pass with the new framework this branch can be merged. |
hsinfang
force-pushed
the
tickets/DM-6999
branch
2 times, most recently
from
3082561
to
0643dbc
Compare
added 3 commits
August 26, 2016 17:04
With the logging framework changes in pipe_base, Tasks' logs is transitioned from lsst.pex.logging to lsst.log. This commit handles the API changes from the framework changes. pex_logging log.logdebug is replaced by lsst.log log.debug.
hsinfang
force-pushed
the
tickets/DM-6999
branch
from
0643dbc
to
bf568b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.