DM-3904: Pytest updates #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Group imports in the standard way. Put all imports at the top. If only a few symbols imported, import them explicitly Spell out lsst.utils.tests instead of using utilsTests
Set up an environment variable in setUpClass instead of globally Replace "if __name__ == "__main__" with the standard replacement
Modernize the way the test is run. Use "with assertRaises(...):" instead of "self.assertRaises(...)"
|
|
||
| if __name__ == "__main__": | ||
| run(True) | ||
| lsst.utils.tests.init() | ||
| unittest.main() |
r-owen
force-pushed
the
tickets/DM-3904
branch
3 times, most recently
from
154acf6
to
3de6a57
Compare
| print >> fd, s.getId(), s.getXAstrom(), s.getYAstrom(), s.getRa(), s.getDec(), s.getPsfFlux(), s.getFlagForDetection() | ||
| print >> fd, s.getId(), s.getXAstrom(), s.getYAstrom(), s.getRa( | ||
| ), s.getDec(), s.getPsfFlux(), s.getFlagForDetection() | ||
|
|
There was a problem hiding this comment.
I don't know that this block is more readable autopep8...
There was a problem hiding this comment.
No. It broke at the wrong place and it probably didn't need to break at all for 110 character limit.
Modernize the way it is run for better pytest compatibility. Change self.assertRaises to a "with self.assertRaises"
Replaced one assertTrue with assertIsNone
Don't use utilsTest namespace abbreviation
Remove leading blank line
Change "self.assertRaises(..." to "with self.assertRaises(..."
Use lsst.utils.tests without a namespace abbreviation
Import lsst.utils.tests instead of using namespace abbrev.
Modernize the way the test is run. Only have the classes that need to be run inherit from TestCase
Change assertTrue(foo in bar) with assertIn(foo, bar)
Import lsst.utils.tests without namespace abbreviation Use from foo import bar when only a few symbols imported
Change "self.assertRaises..." to "with self.assertRaises..."
Also change module global to local
Standardize the way ASTROMETRY_NET_DATA_DIR is set by tests, and make sure it is always done in setUp
r-owen
force-pushed
the
tickets/DM-3904
branch
from
3de6a57
to
50f45d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.